Extract and document path manipulation utilities #514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
thechenky
approved these changes
Jul 11, 2019
Contributor
thechenky
left a comment
thechenky
left a comment
There was a problem hiding this comment.
Looks good, thanks for doing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on a small fix I wanted to add a utility function that could be reused across the codebase. I noticed that all utilities live in one file, which makes it too easy to throw everything in there. I started by removing an unused function in #513. This PR extracts path manipulation utilities into its own file. I created
utilitiesdirectory, so more well-named, well-scoped files and methods can be added there.Code sample
Not relevant.