Skip to content

Add code comments for storage events #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 12, 2019
Merged

Add code comments for storage events #517

merged 3 commits into from
Jul 12, 2019

Conversation

@esmacik
Copy link
Contributor

@esmacik esmacik commented Jul 11, 2019

Add code comments for storage events mostly from existing storage-externs.js

@esmacik esmacik requested review from egilmorez and thechenky July 11, 2019 21:40
@thechenky
Copy link
Contributor

thechenky commented Jul 11, 2019

@esmacik can you run npm run format:fix and commit the changes? We check formatting in the continuous tests in travis - the tests are currently failing because formatting is off. I would suggest running npm run format:fix before every commit to ensure proper formatting 😄

@esmacik esmacik requested a review from kevinajian as a code owner July 11, 2019 23:49
thechenky
thechenky approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@thechenky thechenky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@thechenky thechenky merged commit 273c5ff into master Jul 12, 2019
@esmacik esmacik deleted the em-storage branch July 12, 2019 17:27
@esmacik esmacik restored the em-storage branch July 12, 2019 17:27
@esmacik esmacik deleted the em-storage branch July 12, 2019 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@egilmorez egilmorez Awaiting requested review from egilmorez

@kevinajian kevinajian Awaiting requested review from kevinajian

1 more reviewer

@thechenky thechenky thechenky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@esmacik @thechenky