Fix exhaustiveness of error code switch in http status conversion #520
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is only a type safety change, does not change actual behaviour. Whereas the comment before the default stated that it should never get there unless TypeScript does its job, it didn't hold true - an error was thrown in the default case, which is a branch of execution that is perfectly correct. An unreachable code is represented by a
nevertype in TypeScript.This PR adds a function that accepts a parameter of type
never, which will not be allowed by the compiler. If the impossible happens, a readable error will be thrown.Code sample