Adding code comments to remoteConfig.ts source #524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thechenky
suggested changes
Jul 15, 2019
Contributor
thechenky
left a comment
thechenky
left a comment
There was a problem hiding this comment.
Added some suggestions on phrasing, PTAL.
Co-Authored-By: Diana Tkachenko <31747099+thechenky@users.noreply.github.com>
Co-Authored-By: Diana Tkachenko <31747099+thechenky@users.noreply.github.com>
Co-Authored-By: Diana Tkachenko <31747099+thechenky@users.noreply.github.com>
Co-Authored-By: Diana Tkachenko <31747099+thechenky@users.noreply.github.com>
Co-Authored-By: Diana Tkachenko <31747099+thechenky@users.noreply.github.com>
Co-Authored-By: Diana Tkachenko <31747099+thechenky@users.noreply.github.com>
Contributor
|
@esmacik could you have more descriptive commit messages? Then it would be helpful to understand what changed in the commit just by looking at the name. Also, these changes are all so small, feel free to commit them all in one commit. I know we said small is good, but just letting you know it's okay to combine all these :) |
kevinajian
approved these changes
Jul 15, 2019
Contributor
Author
|
@thechenky definitely! And for those small commits I was just following the GitHub GUI. Sorry about that! |
Contributor
|
Can you pull in master? Then I can merge it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding source code comments to remoteConfig.js, mostly from the existing remoteConfig-externs.js file