Linking to external types - docgen

[esmacik]

This is the first iteration of my solution to linking to external library types for the Firebase Functions Reference documentation.

1. Map external types to their links.
2. Create a DOM of each HTML file.
3. When fixing links, intersect HTML data of generated doc and query tags of type tsd-signature-type.
4. Add link to matching types

In these staged files, there are now links to UserInfo, UserRecord, and DocumentSnapshot types:

• functions.auth
• functions.auth.UserBuilder
• functions.firestore
• functions.firestore.DocumentBuilder

[hiranya911]

Looks mostly good. Just a few suggestions to improve on.

[thechenky]

Not immediately clear why we're selecting .tsd-signature-type?

[thechenky]

I would add a comment here explaining why this tag, so that the next contributor knows the context.

[egilmorez]

Adding what I think Erik was doing -- just picking an ID to iterate through that would always be associated with potential external types in TypeDoc.

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[joehan]

Code looks fine to me, and after looking thru the staging site, the choice of .tsd-signature-type seems appropriate. However, in the description, it says that DocumentSnapshot should now be hyperlinked on the staged site, and I don't see that. Has this code just been unstaged in the past few months?

Checked with Hiranya offline; all has been address afaict.

[joehan]

@googlebot I fixed it.

[googlebot]

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

[googlebot]

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

[joehan]

Overriding the CLA bot here, as we have a CLA from the commit author from a different email, and the commits causing the check to fail are from github.