fix: onCreate, onUpdate and onDelete receive a DocumentQuerySnapshopt #670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The arguments of Firestore triggers `onCreate`, `onUpdate` and `onDelete` cannot have an undefined data by definition, so we changed the arguments of those handlers to reflect that by using DocumentQuerySnapshot. fixes firebase#659
joehan
approved these changes
Apr 24, 2020
Contributor
joehan
left a comment
joehan
left a comment
There was a problem hiding this comment.
This LGTM! Thanks for making the switch. @laurenzlong will probably review as well.
laurenzlong
approved these changes
Apr 27, 2020
Contributor
laurenzlong
left a comment
laurenzlong
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arguments of Firestore triggers
onCreate,onUpdateandonDeletecannot have an undefined data by definition, so we changed the arguments of those handlers to reflect that by using DocumentQuerySnapshot.fixes #659