Updates logging in https callable functions. #745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenzlong
approved these changes
Jul 30, 2020
Contributor
Author
|
Travis passed CI but didn't report back for some reason. Merging. https://travis-ci.org/github/firebase/firebase-functions/builds/710809787 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#744 brought to my attention that we need to update our internal logging for HTTPS callable functions to be compatible with the new Node 10+ logging style.
I've taken a pass to update any instance of
console.*to the appropriate logger method, and also taken the suggestion to remove logging the full request body on invalid argument.