Skip to content

Update integration test so that it works again. #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 3, 2021
Merged

Update integration test so that it works again. #869

merged 3 commits into from
Mar 3, 2021

Conversation

@inlined
Copy link
Member

@inlined inlined commented Mar 2, 2021

Description

Fixes integration tests.

  • Updated node versions under test
  • Updated node dependencies to modern versions
  • Removed lodash dependency
  • Minor updates to TypeScript annotations/style
  • Fix URL and authentication when invoking a cloud schedule
  • Fix Cloud Schedule test to not finish until tests are complete

Code sample

cd integration_test && ./run_tests.sh <project_id>

@inlined
Update integration test so that it works again.
3b98f8f 
* Updated node versions under test
* Updated node dependencies to modern versions
* Removed lodash dependency
* Minor updates to TypeScript annotations/style
* Fix URL and authentication when invoking a cloud schedule
* Fix Cloud Schedule test to not finish until tests are complete
@inlined inlined requested a review from joehan March 2, 2021 19:26
@inlined
Copy link
Member Author

inlined commented Mar 2, 2021

Fixes #865

joehan
joehan approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@joehan joehan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning these up! Looks like you need to npm run format to get the tests running again.

@inlined inlined merged commit ee793c7 into master Mar 3, 2021
@inlined inlined deleted the inlined.fix-integration-tests branch March 5, 2021 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joehan joehan joehan approved these changes

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@inlined @joehan @googlebot