Skip to content

Conversation

@mbleigh
Copy link
Contributor

@mbleigh mbleigh commented Jul 13, 2021

Recent file renames caused docgen to create lots of broken links. This PR does a few small things:

  1. Fixes the links for docgen.
  2. Changes the default for docgen to explicitly build the v1 and logger folders since that's where all the things we want to document reside.
  3. Improves the logic of the broken link warnings for docgen.
  4. Marks removeCircular as internal because it was showing up in docs despite not being exported.

Copy link
Member

@inlined inlined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An fix to the status quo though we might need more on top of this. LGTM.

@mbleigh mbleigh merged commit 5e7fb2c into master Jul 13, 2021
@mbleigh mbleigh deleted the mb-docgen branch July 13, 2021 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants