Adds multiple api version support to docgen. #924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inlined
reviewed
Jul 29, 2021
Member
inlined
left a comment
inlined
left a comment
There was a problem hiding this comment.
Surprisingly straightforward. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
--sourceflag that was previously used for docgen into a--apiflag that takes eitherv1orv2as a value (defaulting tov1).This allows us to have dual
content-sourcesdirectories for each version and will hopefully give us what we need for the short term at least.Also fixes a bug where since there are no classes in the v2 namespace it was erroring out.