Skip to content

Conversation

@andrewheard
Copy link
Contributor

  • Fixed the googleAI_v1beta_appCheckLimitedUse InstanceConfig in the Firebase AI Logic integration tests.

    • This configuration was previously using standard tokens.
    • This config was showing as (copy) to signify that it was identical to the other.
      Xcode Duplicate Test Case Screenshot
  • Simplified nil checking in LiveSessionsTests with try #require(...) instead of guard let ... else { Issue.record(...) } pattern.

  • Fixed location formatting in test case naming.

    • googleAI_v1beta_appCheckLimitedUse now shows Google AI (v1beta) - FAC Limited-Use
    Xcode Test Cases Screenshot

#no-changelog

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several improvements to the Firebase AI integration tests. The main fix correctly configures the googleAI_v1beta_appCheckLimitedUse test instance to use limited-use App Check tokens, which was the primary goal. Additionally, the code is refactored to use the try #require(...) pattern from the Swift Testing framework, simplifying nil-checking and making the tests more concise. The PR also enhances readability by improving test case naming for different configurations and clarifying a TODO comment. Overall, these are solid changes that improve the correctness and maintainability of the test suite.

# Conflicts:
#	FirebaseAI/Tests/TestApp/Tests/Integration/LiveSessionTests.swift
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes the useLimitedUseAppCheckTokens configuration for Google AI integration tests and improves the codebase by simplifying nil-checking with #require and enhancing test case name formatting. The changes are clear and well-aligned with the PR's description. I've added one minor suggestion for consistency in string handling within the test setup.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@andrewheard andrewheard marked this pull request as ready for review October 21, 2025 22:33
@andrewheard andrewheard requested a review from daymxn October 22, 2025 16:43
@andrewheard andrewheard merged commit d5b6dec into main Oct 22, 2025
96 of 97 checks passed
@andrewheard andrewheard deleted the ah/firebaseai-fac-integration branch October 22, 2025 17:07
andrewheard added a commit that referenced this pull request Oct 31, 2025
)

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants