-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add a mechanism to prevent concurrent token refreshes #15493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
88fc659 to
4608cf2
Compare
When multiple different firebase services require a token refresh at the same time, multiple token refresh can be triggered at the same time inside the SecureTokenService. This PR makes sure only one token refresh is happening at the same time
4608cf2 to
b59cc72
Compare
ncooke3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
FirebaseAuth/Sources/Swift/SystemService/TokenRefreshCoalescer.swift
Outdated
Show resolved
Hide resolved
|
@lilpit, thanks again for the fix! Question, in the sample project, was there a purpose to Remote Config for reproducing the original issue? My understanding is that the flow was: sign in, let token expire, re-open app to kick off token refresh and manually trigger the two document refreshes which will also kick spawn token refreshes (3 in total). What role did the remote config fetch play? |
When multiple different firebase services require a token refresh at the same time, multiple token refresh can be triggered at the same time inside the SecureTokenService.
This PR makes sure only one token refresh is happening at the same time
Discussion
Testing
Testing scenario:
API Changes