Skip to content

Conversation

@lilpit
Copy link
Contributor

@lilpit lilpit commented Nov 13, 2025

When multiple different firebase services require a token refresh at the same time, multiple token refresh can be triggered at the same time inside the SecureTokenService.

This PR makes sure only one token refresh is happening at the same time

Discussion

Testing

  • Added some unit tests to test concurrent reload behaviors
  • Tested this branch in our sample project where we reproduce the issue -> the issue is gone
    Testing scenario:
  • Open the sample app
  • Wait for 1 hour for token expirtation
  • Re open the sample app -> only one token refresh is performed instead of multiple one

API Changes

  • No API changes

@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@google-cla
Copy link

google-cla bot commented Nov 13, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

When multiple different firebase services require a token refresh at the same time, multiple token refresh can be triggered at the same time inside the SecureTokenService.

This PR makes sure only one token refresh is happening at the same time
@lilpit lilpit force-pushed the concurrentRequestsHandling branch from 4608cf2 to b59cc72 Compare November 13, 2025 15:02
@ncooke3 ncooke3 self-requested a review November 13, 2025 16:38
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@ncooke3
Copy link
Member

ncooke3 commented Nov 24, 2025

@lilpit, thanks again for the fix! Question, in the sample project, was there a purpose to Remote Config for reproducing the original issue? My understanding is that the flow was: sign in, let token expire, re-open app to kick off token refresh and manually trigger the two document refreshes which will also kick spawn token refreshes (3 in total). What role did the remote config fetch play?

https://github.com/thibaudse/firebase-concurrency-issue-mcve/blob/main/firebase-concurrency-issue-mcve/Trigger.swift

@ncooke3 ncooke3 merged commit 8dd8e89 into firebase:main Nov 24, 2025
53 of 54 checks passed
ncooke3 added a commit that referenced this pull request Nov 24, 2025
ncooke3 added a commit that referenced this pull request Nov 24, 2025
@paulb777 paulb777 added this to the 12.7.0 - M174 milestone Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants