Skip to content

GUL Debug app to test Keychain access in the background #5828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

GUL Debug app to test Keychain access in the background #5828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1f8ed56
GULKeychainStorageTestApp
maksymmalyhin Jun 15, 2020
e049b9d
Display User Notification on background fetch
maksymmalyhin Jun 15, 2020
2a7c5c4
Formatting
maksymmalyhin Jun 15, 2020
596adbb
++
maksymmalyhin Jun 15, 2020
bd2b573
Move test app to GUL directory. Use background location updates to ac…
maksymmalyhin Jun 17, 2020
0070131
Tests with visit API
maksymmalyhin Jul 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion GoogleUtilities.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ other Google CocoaPods. They're not intended for direct public usage.
s.subspec 'Environment' do |es|
es.source_files = 'GoogleUtilities/Environment/**/*.[mh]'
es.public_header_files = 'GoogleUtilities/Environment/**/*.h'
es.private_header_files = 'GoogleUtilities/Environment/**/*.h'
# es.private_header_files = 'GoogleUtilities/Environment/**/*.h'

es.dependency 'PromisesObjC', '~> 1.2'
end
Expand Down
26 changes: 13 additions & 13 deletions GoogleUtilities/Environment/SecureStorage/GULKeychainStorage.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ - (instancetype)initWithService:(NSString *)service cache:(NSCache *)cache {
_inMemoryCacheQueue =
dispatch_queue_create("com.gul.KeychainStorage.InMemoryCache", DISPATCH_QUEUE_SERIAL);
_service = [service copy];
_inMemoryCache = cache;
// _inMemoryCache = cache;
}
return self;
}
Expand All @@ -60,22 +60,22 @@ - (instancetype)initWithService:(NSString *)service cache:(NSCache *)cache {
- (FBLPromise<id<NSSecureCoding>> *)getObjectForKey:(NSString *)key
objectClass:(Class)objectClass
accessGroup:(nullable NSString *)accessGroup {
return [FBLPromise onQueue:self.inMemoryCacheQueue
do:^id _Nullable {
// Return cached object or fail otherwise.
id object = [self.inMemoryCache objectForKey:key];
return object
?: [[NSError alloc]
initWithDomain:FBLPromiseErrorDomain
code:FBLPromiseErrorCodeValidationFailure
userInfo:nil];
}]
.recover(^id _Nullable(NSError *error) {
// return [FBLPromise onQueue:self.inMemoryCacheQueue
// do:^id _Nullable {
// // Return cached object or fail otherwise.
// id object = [self.inMemoryCache objectForKey:key];
// return object
// ?: [[NSError alloc]
// initWithDomain:FBLPromiseErrorDomain
// code:FBLPromiseErrorCodeValidationFailure
// userInfo:nil];
// }]
// .recover(^id _Nullable(NSError *error) {
// Look for the object in the keychain.
return [self getObjectFromKeychainForKey:key
objectClass:objectClass
accessGroup:accessGroup];
});
// });
}

- (FBLPromise<NSNull *> *)setObject:(id<NSSecureCoding>)object
Expand Down
2 changes: 1 addition & 1 deletion GoogleUtilities/Environment/SecureStorage/GULKeychainUtils.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ + (BOOL)setItem:(NSData *)item

NSMutableDictionary *mutableQuery = [query mutableCopy];
mutableQuery[(__bridge id)kSecAttrAccessible] =
(__bridge id)kSecAttrAccessibleAfterFirstUnlockThisDeviceOnly;
(__bridge id)kSecAttrAccessibleWhenUnlockedThisDeviceOnly;

OSStatus status;
if (!existingItem) {
Expand Down
Loading