Skip to content

Explicit async/await implementations for previous implicit ones #9478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2022
Merged

Explicit async/await implementations for previous implicit ones #9478

merged 2 commits into from
Mar 20, 2022

Conversation

@paulb777
Copy link
Member

@paulb777 paulb777 commented Mar 18, 2022

#no-changelog

@paulb777 paulb777 requested a review from ncooke3 March 18, 2022 23:13
ncooke3
ncooke3 approved these changes Mar 20, 2022
View reviewed changes
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@paulb777 paulb777 merged commit 96c2e50 into storage-v9 Mar 20, 2022
@paulb777 paulb777 deleted the pb-storage-explicit-async-await branch March 20, 2022 17:37
paulb777 added a commit that referenced this pull request Mar 20, 2022
@paulb777
Explicit async/await implementations for previous implicit ones (#9478)
6134e5b
paulb777 added a commit that referenced this pull request Mar 21, 2022
@paulb777
Explicit async/await implementations for previous implicit ones (#9478)
6524524
paulb777 added a commit that referenced this pull request Mar 23, 2022
@paulb777
Explicit async/await implementations for previous implicit ones (#9478)
ab38520
paulb777 added a commit that referenced this pull request Mar 23, 2022
@paulb777
Explicit async/await implementations for previous implicit ones (#9478)
5814479
paulb777 added a commit that referenced this pull request Mar 30, 2022
@paulb777
Explicit async/await implementations for previous implicit ones (#9478)
5f3091a
paulb777 added a commit that referenced this pull request Mar 30, 2022
@paulb777
Explicit async/await implementations for previous implicit ones (#9478)
8d15151
paulb777 added a commit that referenced this pull request Apr 4, 2022
@paulb777
Explicit async/await implementations for previous implicit ones (#9478)
5c70636
paulb777 added a commit that referenced this pull request Apr 4, 2022
@paulb777
Explicit async/await implementations for previous implicit ones (#9478)
cfe1810
@firebase firebase locked and limited conversation to collaborators Apr 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

Assignees

No one assigned

Labels

api: storage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paulb777 @ncooke3 @google-oss-bot