Changing the outputDir of connector.yaml does not work properly

[marcusx2]

Operating System

all

Environment (if applicable)

all

Firebase SDK Version

12.4.0

Firebase SDK Product(s)

DataConnect

Project Tooling

Visual Studio Code and DataConnect extension under Windows 11

Detailed Problem Description

Changing the outputDir of the dataconnect sdk does not work as expected

If I change the output folder and keep doing the codelab, the MovieService.tsx won't find the new imports.

The reason is, even though I changed the outputDir in the connector.yaml file, all the imports still point to the original path of dataconnect

which is ../../app/src/lib/dataconnect-sdk

In addition, the index.d.ts is not updated in the old path or the new path.

Steps and code to reproduce issue

all

[google-oss-bot]

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

[maneesht]

This is something we'll look into. In the meantime, you can run:

firebase dataconnect:sdk:generate
npm i <path to updated sdk>

[looptheloop88]

Hi @marcusx2, apologies for the delay in response. I tried replicating the issue, but it's working fine on my end.

If you are using the Firebase Data Connect Visual Studio Extension, it will keep the generated SDK updated.

I can confirm that updating the value or path of outputDir in dataconnect > movie-connector > connector.yaml file will automatically generate a new SDK package, and all references of this package will also be updated. You can check this in package.json file, under dependencies.

[marcusx2]

@looptheloop88

I am not sure which package.json you are talking about, but all of them point to the old path for me. I am using the dataconnect extension

The original path is under C:, the changed under D:, not sure if that makes a difference.

When I change the path, the folder is generated at the correct path once, but making further changes to the schema, queries, or mutations, doesn't work.

The MovieService.tsx, it points to the old path still under C:, not the path I specified under D:

[looptheloop88]

Hi @marcusx2, the package.json file is located within the app directory.

I am currently using a Mac machine and haven't tried reproducing the issue on a Windows machine. I think this is not a JS SDK issue, so could you please file a new issue on firebase-tools repository? Thanks!