Skip to content

Fix inverted emulator port examples #6024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix inverted emulator port examples #6024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d81c175
Use default Firestore emulator port as example
danizord Feb 21, 2022
d89406d
Use default RealtimeDB emulator port as example
danizord Feb 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/database/src/api/Database.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ export function getDatabase(
*
* @param db - The instance to modify.
* @param host - The emulator host (ex: localhost)
* @param port - The emulator port (ex: 8080)
* @param port - The emulator port (ex: 9000)
* @param options.mockUserToken - the mock auth token to use for unit testing Security Rules
*/
export function connectDatabaseEmulator(
Expand Down
2 changes: 1 addition & 1 deletion packages/firestore/src/lite-api/database.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ export { EmulatorMockTokenOptions } from '@firebase/util';
* @param firestore - The `Firestore` instance to configure to connect to the
* emulator.
* @param host - the emulator host (ex: localhost).
* @param port - the emulator port (ex: 9000).
* @param port - the emulator port (ex: 8080).
* @param options.mockUserToken - the mock auth token to use for unit testing
* Security Rules.
*/
Expand Down