Skip to content

Post-indexeddbshim test fixes #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2018
Merged

Post-indexeddbshim test fixes #753

merged 1 commit into from
May 1, 2018

Conversation

mikelehen
Copy link
Contributor

  1. We weren't actually calling db.INTERNAL.delete(), leading to lingering webchannel connections in tests.
  2. Fixed a missed reference to mock_persistence.ts.

@mikelehen mikelehen requested a review from wilhuff as a code owner May 1, 2018 01:17
@mikelehen mikelehen merged commit 9751e46 into master May 1, 2018
@mikelehen mikelehen deleted the mikelehen/fix-shutdown branch May 1, 2018 16:01
@firebase firebase locked and limited conversation to collaborators Oct 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wilhuff wilhuff Awaiting requested review from wilhuff

1 more reviewer

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@schmidt-sebastian schmidt-sebastian

Labels

api: firestore needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mikelehen @schmidt-sebastian @google-oss-bot