Skip to content

Set FirebaseError name to be calling constructors name #8553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Set FirebaseError name to be calling constructors name #8553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c04d9ef
Add node engines fields specifying a minimum of 18 (#8457)
hsubox76 Sep 3, 2024
a377fb2
Make memory lru gc the default (#8110)
wu-hui Sep 9, 2024
c8937e7
V11 release removal of node-fetch and undici dependencies (#8492)
DellaBitta Sep 20, 2024
7194d9c
Merge branch 'main' into v11
hsubox76 Sep 20, 2024
d253484
V11 - Remove functions node bundle (#8507)
DellaBitta Sep 23, 2024
097bd67
Initial changes for Vertex GA packaging (#8498)
hsubox76 Sep 23, 2024
09ba48f
[Vertex GA] Rewrite Schema (#8479)
hsubox76 Sep 24, 2024
245e65e
[Vertex GA] Add new endpoint and error message. (#8497)
hsubox76 Sep 24, 2024
3fe4f4f
[Vertex GA] Miscellaneous breaking changes for Vertex GA (#8514)
hsubox76 Sep 24, 2024
36cb017
Remove ES5 Support (#8509)
dlarocque Sep 25, 2024
6b035b7
Emit a module package file for functions ESM builds (#8517)
dlarocque Sep 26, 2024
07b203a
Set FirebaseError names to be calling constructors name
dlarocque Sep 30, 2024
23a5fef
Add changeset
dlarocque Sep 30, 2024
ac00980
Remove unused `ERROR_NAME`
dlarocque Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/chatty-walls-wink.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@firebase/util': patch
---

Set FirebaseError names to be the calling constructors name.
6 changes: 6 additions & 0 deletions .changeset/large-snakes-march.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'firebase': major
'@firebase/vertexai': major
---

Release VertexAI in Firebase for general availability.
36 changes: 36 additions & 0 deletions .changeset/little-cows-tie.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
---
'@firebase/installations-compat': patch
'@firebase/remote-config-compat': patch
'@firebase/performance-compat': patch
'@firebase/rules-unit-testing': patch
'@firebase/webchannel-wrapper': patch
'@firebase/analytics-compat': patch
'@firebase/app-check-compat': patch
'@firebase/firestore-compat': patch
'@firebase/functions-compat': patch
'@firebase/messaging-compat': patch
'@firebase/database-compat': patch
'@firebase/storage-compat': patch
'@firebase/installations': patch
'@firebase/remote-config': patch
'@firebase/auth-compat': patch
'@firebase/performance': patch
'@firebase/app-compat': patch
'@firebase/analytics': patch
'@firebase/app-check': patch
'@firebase/component': patch
'@firebase/firestore': patch
'@firebase/functions': patch
'@firebase/messaging': patch
'@firebase/database': patch
'firebase': patch
'@firebase/template': patch
'@firebase/vertexai-preview': patch
'@firebase/storage': patch
'@firebase/logger': patch
'@firebase/auth': patch
'@firebase/util': patch
'@firebase/app': patch
---

Remove ES5 bundles. The minimum required ES version is now ES2017.
13 changes: 13 additions & 0 deletions .changeset/plenty-beers-decide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
---
'@firebase/rules-unit-testing': patch
'@firebase/firestore-compat': patch
'@firebase/functions-compat': patch
'@firebase/storage-compat': patch
'@firebase/auth-compat': patch
'@firebase/firestore': patch
'@firebase/functions': patch
'@firebase/storage': patch
'@firebase/auth': patch
---

Removed dependency on undici and node-fetch in our node bundles, replacing them with the native fetch implementation.
6 changes: 6 additions & 0 deletions .changeset/slimy-cups-promise.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@firebase/functions-compat': patch
'@firebase/functions': patch
---

Remove node bundle from the functions SDK as the node-specific fetch code has been removed in favor of using native fetch throughout the SDK.
2 changes: 1 addition & 1 deletion .github/workflows/canary-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ jobs:
NPM_TOKEN_STORAGE: ${{secrets.NPM_TOKEN_STORAGE}}
NPM_TOKEN_STORAGE_TYPES: ${{secrets.NPM_TOKEN_STORAGE_TYPES}}
NPM_TOKEN_UTIL: ${{secrets.NPM_TOKEN_UTIL}}
NPM_TOKEN_VERTEXAI_PREVIEW: ${{secrets.NPM_TOKEN_VERTEXAI_PREVIEW}}
NPM_TOKEN_VERTEXAI: ${{secrets.NPM_TOKEN_VERTEXAI}}
NPM_TOKEN_WEBCHANNEL_WRAPPER: ${{secrets.NPM_TOKEN_WEBCHANNEL_WRAPPER}}
NPM_TOKEN_FIREBASE: ${{secrets.NPM_TOKEN_FIREBASE}}
NPM_TOKEN_APP_COMPAT: ${{ secrets.NPM_TOKEN_APP_COMPAT }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/prerelease-manual-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ jobs:
NPM_TOKEN_STORAGE: ${{secrets.NPM_TOKEN_STORAGE}}
NPM_TOKEN_STORAGE_TYPES: ${{secrets.NPM_TOKEN_STORAGE_TYPES}}
NPM_TOKEN_UTIL: ${{secrets.NPM_TOKEN_UTIL}}
NPM_TOKEN_VERTEXAI_PREVIEW: ${{secrets.NPM_TOKEN_VERTEXAI_PREVIEW}}
NPM_TOKEN_VERTEXAI: ${{secrets.NPM_TOKEN_VERTEXAI}}
NPM_TOKEN_WEBCHANNEL_WRAPPER: ${{secrets.NPM_TOKEN_WEBCHANNEL_WRAPPER}}
NPM_TOKEN_FIREBASE: ${{secrets.NPM_TOKEN_FIREBASE}}
NPM_TOKEN_APP_COMPAT: ${{ secrets.NPM_TOKEN_APP_COMPAT }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-prod.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ jobs:
NPM_TOKEN_STORAGE: ${{secrets.NPM_TOKEN_STORAGE}}
NPM_TOKEN_STORAGE_TYPES: ${{secrets.NPM_TOKEN_STORAGE_TYPES}}
NPM_TOKEN_UTIL: ${{secrets.NPM_TOKEN_UTIL}}
NPM_TOKEN_VERTEXAI_PREVIEW: ${{secrets.NPM_TOKEN_VERTEXAI_PREVIEW}}
NPM_TOKEN_VERTEXAI: ${{secrets.NPM_TOKEN_VERTEXAI}}
NPM_TOKEN_WEBCHANNEL_WRAPPER: ${{secrets.NPM_TOKEN_WEBCHANNEL_WRAPPER}}
NPM_TOKEN_FIREBASE: ${{secrets.NPM_TOKEN_FIREBASE}}
NPM_TOKEN_APP_COMPAT: ${{ secrets.NPM_TOKEN_APP_COMPAT }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-staging.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ jobs:
NPM_TOKEN_STORAGE: ${{secrets.NPM_TOKEN_STORAGE}}
NPM_TOKEN_STORAGE_TYPES: ${{secrets.NPM_TOKEN_STORAGE_TYPES}}
NPM_TOKEN_UTIL: ${{secrets.NPM_TOKEN_UTIL}}
NPM_TOKEN_VERTEXAI_PREVIEW: ${{secrets.NPM_TOKEN_VERTEXAI_PREVIEW}}
NPM_TOKEN_VERTEXAI: ${{secrets.NPM_TOKEN_VERTEXAI}}
NPM_TOKEN_WEBCHANNEL_WRAPPER: ${{secrets.NPM_TOKEN_WEBCHANNEL_WRAPPER}}
NPM_TOKEN_FIREBASE: ${{secrets.NPM_TOKEN_FIREBASE}}
NPM_TOKEN_APP_COMPAT: ${{ secrets.NPM_TOKEN_APP_COMPAT }}
Expand Down
1 change: 0 additions & 1 deletion common/api-review/util.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,6 @@ export class FirebaseError extends Error {
customData?: Record<string, unknown> | undefined);
readonly code: string;
customData?: Record<string, unknown> | undefined;
readonly name: string;
}

// Warning: (ae-missing-release-tag) "FirebaseSignInProvider" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
Expand Down
Loading
Loading