Throw Operation Not Allowed Exception in FirebaseAuthInterop getUid for… #9325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansisampat
requested review from
a team,
NhienLam,
Xiaoshouzi-gh,
lisajian,
pashanka and
sam-gc
as code owners
|
Vertex AI Mock Responses Check
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
pashanka
reviewed
Oct 21, 2025
| }); | ||
|
|
||
| context('getUid', () => { | ||
| it('returns null if currentUser is undefined', () => { |
There was a problem hiding this comment.
Should this instead say throws error if regionalAuth is initialized? We can add a comment as well to say this is expected as there is no user in regional auth. WDYT?
pashanka
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… regionalAuth
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
getUidmethod in AuthInterop to throw anOperation Not AllowedException for Regional Auth , clearly indicating that regionalized functionality is not yet supported for this method.Testing
API Changes