-
Notifications
You must be signed in to change notification settings - Fork 987
Create overridable constants file #9390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
668366a to
6fa1837
Compare
hsubox76
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be overcautious with that comment but worth a double check. I think almost all build pipelines can process CJS but not sure if there are problems when both CJS and ESM files come from the same dependency.
Also this won't be available for CDN users: https://firebase.google.com/docs/web/alt-setup so that's something to keep in mind - I think it's fine, but we need to document it and tell CDN users to just hardcode it into the init options, and this autoconstants route won't be an option for them.
061bce5 to
ad7a709
Compare
Discussion
Adds a new "auto-constants" file that is not bundled into the index.js output. It can optionally be overwritten during the application's build process to automatically set "app version" based on context (eg. git commit hash, deployment id, etc.).
Testing
Unit tested, manually tested
API Changes
n/a