Add support for VPC direct connect in GCF 2nd gen by inlined · Pull Request #10033 · firebase/firebase-tools

inlined · 2026-03-06T20:11:32Z

Companion PR to firebase/firebase-functions#1823.

Successfully tested e2e with

gemini-code-assist · 2026-03-06T20:11:52Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces comprehensive support for VPC direct connect functionality for Google Cloud Functions 2nd generation. This feature allows users to define specific network interfaces for their functions, enabling direct and secure communication within their Google Cloud VPC without relying solely on VPC connectors. The changes involve significant updates to internal data models, parameter resolution, and the translation layer that interfaces with the Cloud Functions v2 API, ensuring seamless integration and deployment of functions with direct VPC connectivity.

Highlights

Direct VPC Network Interface Support: Enabled the configuration of direct VPC network interfaces for Google Cloud Functions (GCF) 2nd generation, allowing functions to connect directly to specified networks and subnetworks.
Updated Data Models: Modified internal data structures, including ServiceConfiguration, VpcSettings, and WireEndpoint, to incorporate networkInterfaces as a new option within VPC settings.
Enhanced Translation Logic: Implemented and updated conversion functions (functionFromEndpoint, endpointFromFunction, toBackend) to correctly translate networkInterfaces and egressSettings between the internal endpoint representation and the GCP Cloud Functions v2 API.
Flexible VPC Validation: Adjusted validation rules to allow a VPC configuration to specify either a traditional VPC connector or direct network interfaces, providing more flexibility in deployment.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

src/deploy/functions/backend.ts
- Made vpc.connector optional in the ServiceConfiguration interface.
- Added vpc.networkInterfaces to the ServiceConfiguration interface.
src/deploy/functions/build.spec.ts
- Added a new test case to verify that networkInterfaces are correctly populated from parameter values.
src/deploy/functions/build.ts
- Made connector optional and nullable in the VpcSettings interface.
- Added networkInterfaces to VpcSettings, allowing network, subnetwork, and tags to be expressions.
- Modified the toBackend function to handle the new networkInterfaces property and conditionally set connector or networkInterfaces.
src/deploy/functions/runtimes/discovery/v1alpha1.ts
- Made vpc.connector optional in the WireEndpoint interface.
- Added vpc.networkInterfaces to the WireEndpoint interface.
- Updated assertBuildEndpoint to validate that either connector or networkInterfaces is specified if VPC settings are present.
src/gcp/cloudfunctionsv2.spec.ts
- Added a test case to ensure networkInterfaces are correctly translated between internal endpoint representation and the GCP Cloud Functions v2 API.
src/gcp/cloudfunctionsv2.ts
- Defined a new DirectVpcEgress type.
- Added directVpcNetworkInterface and directVpcEgress properties to the ServiceConfig interface.
- Modified functionFromEndpoint to map endpoint.vpc.networkInterfaces to directVpcNetworkInterface and egressSettings to directVpcEgress.
- Modified endpointFromFunction to map directVpcNetworkInterface and directVpcEgress back to the internal endpoint.vpc structure.

Activity

No human activity has occurred on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request adds support for VPC direct connect in GCF 2nd gen functions. The changes include updating data structures across the deployment pipeline to accommodate the new networkInterfaces configuration and modifying the translation logic between internal representations and the GCFv2 API. New validation and tests have been added to ensure correctness. The implementation is solid, and I have one minor suggestion to improve code conciseness.

src/deploy/functions/build.ts

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

brittanycho · 2026-03-10T18:17:39Z

src/deploy/functions/runtimes/discovery/v1alpha1.ts

+      networkInterfaces: "array?",
    });
-    requireKeys(prefix + ".vpc", ep.vpc, "connector");
+    if (!ep.vpc.connector && !ep.vpc.networkInterfaces) {


Based on the logic here, it looks like its checking if at least one if present but it also looks like it allows both connector and networkInterfaces to be present (and iiuc, then silently prioritize connector and drop networkInterfaces if both are present)? Do we want to allow clients to provide both or should we log a warning or error if they do?

Great check. Throwing an error.

brittanycho · 2026-03-10T18:20:49Z

src/gcp/cloudfunctionsv2.ts

      );
+    } else if (gcfFunction.serviceConfig.directVpcNetworkInterface) {
+      endpoint.vpc = { networkInterfaces: gcfFunction.serviceConfig.directVpcNetworkInterface };
+      if (


optional nit: wondering if it makes sense to use string replacement or mapping dictionary here to safeguard against any future additions that might not start with "VPC_EGRESS_"?

Yeah doesn't hurt. You're definitely going to hold me to a higher standard for validation it seems 😊

Add support for VPC direct connect in GCF 2nd gen

b201491

Changelog

e8eb672

gemini-code-assist bot reviewed Mar 6, 2026

View reviewed changes

src/deploy/functions/build.ts Outdated Show resolved Hide resolved

inlined and others added 3 commits March 6, 2026 12:14

Update src/deploy/functions/build.ts

9dc0bf0

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Merge branch 'main' into inlined.vpc-dc

bbd97cc

NPM run format

40f0498

brittanycho approved these changes Mar 10, 2026

View reviewed changes

inlined and others added 2 commits March 10, 2026 12:31

PR feedback RE error checking

bf0df0f

Merge branch 'main' into inlined.vpc-dc

a53a130

inlined enabled auto-merge (squash) March 10, 2026 19:44

Merge branch 'main' into inlined.vpc-dc

90d5ea5

inlined merged commit 63808e3 into main Mar 10, 2026
47 checks passed

inlined deleted the inlined.vpc-dc branch March 10, 2026 20:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for VPC direct connect in GCF 2nd gen#10033

Add support for VPC direct connect in GCF 2nd gen#10033
inlined merged 8 commits intomainfrom
inlined.vpc-dc

inlined commented Mar 6, 2026

Uh oh!

gemini-code-assist bot commented Mar 6, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

brittanycho Mar 10, 2026

Uh oh!

inlined Mar 10, 2026

Uh oh!

brittanycho Mar 10, 2026 •

edited

Loading

Uh oh!

inlined Mar 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

inlined commented Mar 6, 2026

Uh oh!

gemini-code-assist bot commented Mar 6, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

brittanycho Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

inlined Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

brittanycho Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

inlined Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

brittanycho Mar 10, 2026 •

edited

Loading