Adding functions/.gitignore when javascript is chosen in firebase init, updating typescript functions/.gitignore

[joehan]

Description

Adding useful default .gitignore files for when the function directory is init - see bug # 72516785

Scenarios Tested

Created a new javascript functions project, functions/.gitignore exists
Created a new typescript functions project, functions/.gitignore includes the new additions

[coveralls]

Coverage remained the same at 60.117% when pulling 8792c1f on jh-add-gitignore into 07f792c on master.

[coveralls]

Coverage remained the same at 60.117% when pulling 8792c1f on jh-add-gitignore into 07f792c on master.

[coveralls]

Coverage remained the same at 60.117% when pulling 7e6ab55 on jh-add-gitignore into 7c01343 on master.

[bkendall]

If I create a file structure:

project/
  functions/
    lib/
      [built files]
    src/
      index.ts
      lib/
        foo.ts

src/lib/foo.ts is ignored because of this rule (and so does lib/, which is intended). just saying lib/ is a little too open (though I get that we want to ignore built files).

That said, there are two options:

• assuming the lib directory will always contain built js and js.map files (as ignored above), we should remove lib from .gitignore. No files other than those two extensions means that git will ignore the directory
• if we want to allow lib folders elsewhere (and not cause headaches for folks, probably a good idea), we should include the line !src/**/lib/ which tells it to allow any folder named lib as a sub directory of a folder named src

Thoughts?

[jsayol]

Just FYI, if you use either /lib/ or lib/**/* it will only match from the root (or rather, from the location of the .gitingore file) which is probably what you want.

[bkendall]

Wow. Yup. I struggled to get that right. Thank you @jsayol

[joehan]

Good catch - I'm going to remove the line, since it doesn't look like the Typescript compiler will put any files other than .js or js.map files into the output directory. If there is something else in there that wouldn't be matched by the first 2 rules, it was probably added by the developer for some reason, and ignoring it by default is probably not the expected behavior. Also, if the user changes the output directory for some reason, the /lib/ rule will be extraneous.

[thechenky]

I think we should still consider adding /lib/ to the .gitignore for typescript, and that will match only the root level lib, which contains the built files, and not pick up anything else.

[bkendall]

I'm approving this, though assigning to @thechenky for final 👍

Also, consider if a line should be added to changelog.txt for this change (ask @thechenky or @bkendall) for a reference about the format if you're unclear)

[bkendall]

(I also just updated with master, so if you change something locally, git pull first before you commit)