Validate emulator download by checking file size #1144
Conversation
bkendall
left a comment
bkendall
left a comment
There was a problem hiding this comment.
Looks like you need to run npm run format and you'll be good to go for the tests.
Why use the size rather than a hash? I can see either working okay, but hash would be slightly better in my opinion
|
src/emulator/download.js
Outdated
| let tmpFile = tmp.fileSync(); | ||
| let req = request.get(emulator.remoteUrl); | ||
| let writeStream = fs.createWriteStream(tmpFile.name); | ||
| let bytesDownloaded = 0; |
There was a problem hiding this comment.
doesn't look like this is used
|
|
Went ahead and added a checksum as well. Code is now a bit messy, would appreciate pointers here. |
bkendall
left a comment
bkendall
left a comment
There was a problem hiding this comment.
looks good - I suggested a bit of refactoring around your else statements that should make it a bit nicer, but looks good from here!
src/emulator/download.js
Outdated
| { exit: 1 } | ||
| ) | ||
| ); | ||
| } else { |
There was a problem hiding this comment.
this else block can be removed if the reject above is returned
There was a problem hiding this comment.
(and the same is true of the else block that this entire check is in)
There was a problem hiding this comment.
converted these to ternary statements, lmk if that's non-idiomatic
src/emulator/download.js
Outdated
| const hash = crypto.createHash('md5'), | ||
| const stream = fs.createReadStream(tmpFile.name); | ||
| stream.on('data', data => hash.update(data)); | ||
| stream.on('end', function() { |
There was a problem hiding this comment.
this can be an arrow function
src/emulator/download.js
Outdated
| stream.on('data', data => hash.update(data)); | ||
| stream.on('end', function() { | ||
| const checksum = hash.digest('hex'); | ||
| if (checksum != emulator.expectedHash) { |
There was a problem hiding this comment.
| if (checksum != emulator.expectedHash) { | |
| if (checksum !== emulator.expectedHash) { |
|
LGTM. fix up the CI and you're good to go. |
4 participants
There are still customer reports of corrupted downloads that finish successfully. This is a fairly blunt way of double-checking that the download is valid.