Update init templates to use latest Functions and Admin SDKs #1375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thechenky
changed the title
bkendall
requested changes
Jun 7, 2019
Contributor
bkendall
left a comment
bkendall
left a comment
There was a problem hiding this comment.
I don't know why these don't have newlines at the ends of the files. I feel like the newlines should actually be there (some editors strip them).
Also, could you add a changelog.txt entry for this? I don't think it has to be labeled "breaking", but having a note of it may be important.
thechenky
changed the title
Contributor
Author
|
Added changelog entry and fixed the spacing. PTAL. |
bkendall
approved these changes
Jun 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update functions init templates with latest SDK versions. Part of the next major release - functions SDK must be released before the CLI to ensure v3.0.0 is available.
This change also changes to use
^instead of~on admin dependency to be consistent with Functions SDK.Scenarios Tested
Did a couple of
firebase initcommands to ensure that all the files are created properly.