Skip to content

Combining apps related commands #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TrCaM wants to merge 74 commits into from
Closed

Combining apps related commands #1492

TrCaM wants to merge 74 commits into from

Conversation

@TrCaM
Copy link
Contributor

@TrCaM TrCaM commented Jul 11, 2019

Description

Merging all code from #1438 and #1477, solving all merge conflicts

TrCaM added 30 commits June 18, 2019 17:48
@TrCaM
Implement api calls to support project creation
28dd281
@TrCaM
Merge branch 'tc-poller' into tc-projects-create-util
269425a
@TrCaM
Addressing comments
bbc0976
@TrCaM
Fix failing test (force restarting travis)
c548b0b
@TrCaM
Merge branch 'tc-poller' into tc-projects-create-util
fe90e76
@TrCaM
Addressing comments v2
dff0751
@TrCaM
Replace nock with sinon to mock api requests
f6adbc3
@TrCaM
Addressing comments
7910faa
@TrCaM
Merge branch 'tc-poller' into tc-projects-create-util
1c32fe2
@TrCaM
Merge branch 'tc-poller' into tc-projects-create-util
9cde985
@TrCaM
To be undone
ff6450b
@TrCaM
Merge branch 'tc-prj-management' into tc-projects-create-util
aa6454f
@TrCaM
export createFirebaseProject() and update tests
2d6423f
@TrCaM
Addressing comments
882cbaa
@TrCaM
Merge branch 'tc-prj-management' into tc-projects-create-util
6fb80d1
@TrCaM
Remove poll helper methods
b535b4c
@TrCaM
Merge branch 'tc-prj-management' into tc-apps-create
0daf8f4
@TrCaM
Implement API calls for apps:create command
938019d
@TrCaM
Implement API calls for apps:create command
2753228
@TrCaM
Matching projects:create code
079fe8c
@TrCaM
Merge branch 'tc-prj-management' of github.com:firebase/firebase-tool…
491bca9 
…s into tc-apps-create
@TrCaM
Implement apps:create command
d142b98
@TrCaM
Fix command description
bad8d0c
@TrCaM
Implement projects:list command
772357b
@TrCaM
Merge branch 'tc-prj-management' into tc-apps-create
eef924a
@TrCaM
Remove --sha-certificate option
c74350d
@TrCaM
Merge branch 'tc-prj-management' into tc-projects-list
e513bf6
@TrCaM
Removing add SHA cert api call
7588d39
@TrCaM
Changes in timeout constant
020a835
@TrCaM
Support providing appStoreId for iOS app creation
5452e2f
TrCaM added 22 commits July 8, 2019 13:47
@TrCaM
Update the command to use getProjectId()
691dae1
@TrCaM
Addressing comments
452e5ad
@TrCaM
Create transform method from string to AppPlatform
96eadcf
@TrCaM
Change listFirebaseApp to accept a single options param
83c1b8a
@TrCaM
More carefull tests with platforms
aefc5c9
@TrCaM
Addressing comments
e1a3fc9
@TrCaM
Refactor unit tests as suggested
14d41e2
@TrCaM
Merge branch 'tc-projects-list' into tc-apps-list
ba7f20f
@TrCaM
Fix unit test
92d5156
@TrCaM
Update unit test following suggestion
04a212d
@TrCaM
Update unit tests as suggestion
814223b
@TrCaM
Moving code out of try block
b433e93
@TrCaM
Introducing AppPlatform.ANY and code refactoring
c18a8e9
@TrCaM
Merge branch 'tc-prj-management' into tc-apps-create
9c5cbba
@TrCaM
move code to apps.ts
9e8ab36
@TrCaM
Add input options interfaces and getAppPlatform
121fc9d
@TrCaM
Move code to apps.ts
ce42800
@TrCaM
Merge branch 'tc-prj-management' into tc-apps-list
4813bd8
@TrCaM
Resolve merge conflict
1f2cf31
@TrCaM
Fix unsaved merge conflict
f0fd4f4
@TrCaM
Fix small typo
7dd87e9
@TrCaM
Merge branch 'tc-apps-list' into tc-app-commands
64b5c3e
@TrCaM TrCaM changed the title Combining projects related commands Combining apps related commands Jul 11, 2019
@googlebot googlebot added the cla: yes Manual indication that this has passed CLA. label Jul 11, 2019
@TrCaM TrCaM requested a review from nbegley July 11, 2019 16:26
@coveralls
Copy link

coveralls commented Jul 11, 2019

Coverage Status

Coverage increased (+0.5%) to 63.048% when pulling 64b5c3e on tc-app-commands into d338640 on tc-prj-management.

@nbegley
Copy link

nbegley commented Jul 11, 2019

Discussed offline - Let's merge your 4 project/app PRs individually rather than in bulk like this PR.

@nbegley nbegley closed this Jul 11, 2019
@TrCaM TrCaM deleted the tc-app-commands branch July 12, 2019 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbegley nbegley Awaiting requested review from nbegley

Assignees

@nbegley nbegley

Labels

cla: yes Manual indication that this has passed CLA.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TrCaM @coveralls @nbegley @googlebot