typescriptifys ensureApiEnabled #1554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e7ec80f.
bkendall
requested changes
Jul 29, 2019
bkendall
approved these changes
Aug 5, 2019
Contributor
bkendall
left a comment
bkendall
left a comment
There was a problem hiding this comment.
This seems fine. Sync to master before squash-and-merge-ing
joehan
added a commit
that referenced
this pull request
Nov 13, 2019
* fix build container to have later npm (#1570) * Release Firestore emulator v1.7.0 (#1571) * Use ADC for Emulator Tests (#1575) * Adds privacy policy link to login notice. (#1576) * Use displayName when available (#1555) * shows displayName if available * formats * uses displayName if available * formats * Declare project and app metadata types (#1470) and update dependencies * Implement projects:create command (#1429) * Implement api calls to support project creation * Initial working command * Replace nock with sinon to mock api requests * export createFirebaseProject() and update tests * Implement projects:create command * Remove poll helper methods * Rename firebase-resource-manager.ts to projectsCreate.ts * Declare project and app metadata types * Update timeout constant * Update unit tests as suggestion * Split metadata.ts into apps.ts and projects.ts * move code to projects.ts * Addressing comment * Implement apps:create command (#1438) * Implement API calls for apps:create command * Implement apps:create command * Remove --sha-certificate option * Support providing appStoreId for iOS app creation * Update the command to use getProjectId() * Update unit tests as suggestion * move code to apps.ts * Add input options interfaces and getAppPlatform * Implement projects:list command (#1465) * Implement projects:list command * Matching changes from metadata * Move code to projects.ts * Resolving TODO * Implement apps:list command (#1477) * Implement apps:list command * Introducing AppPlatform.ANY and code refactoring * Move code to apps.ts * Implement getFirebaseProject and deprecate firebaseApi (#1502) * Re-implement `firebase init` command's default project setup flow (#1506) * Implement getFirebaseProject and deprecate firebaseApi * Implement getProjectPage() and refactor listFirebaseProject() * Implement use an existing project option * Update behavior when there's no project * Implement "Create a new project" option (#1510) * [projects:list] and [apps:list] Logging count (#1526) * Logging total project count after listing. * Logging total app count * Implement apps:sdkconfig command (#1515) * Implement API methods for apps:sdkconfig * Implement apps:sdkconfig command * Add getOrPromptProject function to projects.ts (#1552) * Make getAppPlatform throw if the input platform is unknown * Update changelog for project and app management * Move changelog into CHANGELOG.MD * No more requireAuth() for functions (#1577) * Add the ability to add Firebase resources to an existing GCP project (#1572) * Implement projects:addfirebase command * Update init command to have add Firebase option * implements style fixes suggested in other pr * typescriptifys ensureApiEnabled (#1554) * typescriptifys ensureApiEnabled This reverts commit e7ec80f. * style fixes for switch to ts * Release Firestore emulator v1.7.1 (#1584)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-typescriptifying the file that we reverted yesterday for the patch. Tested this out by deploying a scheduled function successfully to a project that had never used scheduler before - this tested that we were able to successfully check an already enabled api (cloudfunctions.googleapis.com) as well as enable a previously unused api (cloudscheduler.googleapis.com)