Skip to content

Conversation

yuchenshi
Copy link
Member

Description

This is a no-op refactor to rename JavaEmulators to DownloadableEmulators, as a requested follow-up in #1986. It also moves the emulators source file from src/serve to src/emulators to be closer with files that depends on it.

Scenarios Tested

Tested that npm install still compiles and emulators:start still work. Also, type checks are successful so I assume things are fine. Typescript for the win!

Sample Commands

@yuchenshi yuchenshi requested a review from samtstern February 26, 2020 20:58
@googlebot googlebot added the cla: yes Manual indication that this has passed CLA. label Feb 26, 2020
@samtstern
Copy link
Contributor

👍 LGTM as soon as tests pass

@yuchenshi yuchenshi force-pushed the ys/rename-downloadable-emulators branch from c4b3513 to a380e82 Compare February 26, 2020 21:31
@yuchenshi yuchenshi merged commit 169bc81 into master Feb 26, 2020
@yuchenshi yuchenshi deleted the ys/rename-downloadable-emulators branch February 26, 2020 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Manual indication that this has passed CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants