Rename JavaEmulators to DownloadableEmulators. #1997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtstern
approved these changes
Feb 26, 2020
|
👍 LGTM as soon as tests pass |
yuchenshi
force-pushed
the
ys/rename-downloadable-emulators
branch
from
c4b3513 to
a380e82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a no-op refactor to rename
JavaEmulatorstoDownloadableEmulators, as a requested follow-up in #1986. It also moves the emulators source file fromsrc/servetosrc/emulatorsto be closer with files that depends on it.Scenarios Tested
Tested that
npm installstill compiles andemulators:startstill work. Also, type checks are successful so I assume things are fine. Typescript for the win!Sample Commands