Update message when users try to update from 1st to 2nd Gen function #7611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using the same function name. CLI has always block the transition 1st Gen to 2nd Gen in the CLI - change here simply update the product name and point users to our public doc that documents changes necessary to transition to 2nd gen function. Aside: Cloud Run functions doesn't allow for 1st and 2nd gen functions to share the same name.
egilmorez
reviewed
Aug 30, 2024
| have, | ||
| )}] Upgrading from GCFv1 to GCFv2 is not yet supported. Please delete your old function or wait for this feature to be ready.`, | ||
| `[${getFunctionLabel(have)}] Upgrading from 1st Gen to 2nd Gen is not yet supported. ` + | ||
| "Please review https://firebase.google.com/docs/functions/2nd-gen-upgrade before migrating to 2nd Gen.", |
Contributor
There was a problem hiding this comment.
I always feel slightly rude making this comment, but our developer style guide advises against "please." I'd suggest the simple and direct "See ."
egilmorez
reviewed
Aug 30, 2024
| `[${getFunctionLabel( | ||
| have, | ||
| )}] Upgrading from GCFv1 to GCFv2 is not yet supported. Please delete your old function or wait for this feature to be ready.`, | ||
| `[${getFunctionLabel(have)}] Upgrading from 1st Gen to 2nd Gen is not yet supported. ` + |
Contributor
There was a problem hiding this comment.
When do we actually display this? On deployment of a scheduled function I guess?
Contributor
Author
There was a problem hiding this comment.
On firebase deploy when we detect that there exists 1st Gen function whose name is same as a 2nd Gen function you have in your source.
milyes
approved these changes
Aug 30, 2024
joehan
approved these changes
Sep 10, 2024
tammam-g
pushed a commit
that referenced
this pull request
Sep 13, 2024
…7611) * Update message when users try to update from 1st to 2nd Gen function using the same function name. CLI has always block the transition 1st Gen to 2nd Gen in the CLI - change here simply update the product name and point users to our public doc that documents changes necessary to transition to 2nd gen function. Aside: Cloud Run functions doesn't allow for 1st and 2nd gen functions to share the same name. * messaging nit. * Say 'see' instead of 'please'. --------- Co-authored-by: joehan <joehanley@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLI has always block the transition 1st Gen to 2nd Gen in the CLI - change here simply update the product name and point users to our public doc that documents changes necessary to transition to 2nd gen function.
Aside: Cloud Run functions doesn't allow for 1st and 2nd gen functions to share the same name.