Skip to content

Fix extension hanging during Firebase Init #7630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 10, 2024
Merged

Fix extension hanging during Firebase Init #7630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
760865a
remove requireAuthWrapper loop
hlshen Sep 7, 2024
d23bcd5
changelog
hlshen Sep 7, 2024
b15fd4a
Update firebase-vscode/src/cli.ts
hlshen Sep 10, 2024
b351493
Apply suggestions from code review
hlshen Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions firebase-vscode/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
## NEXT

- [Fixed] Extension properly picks up firebase.json changes during Firebase Init flow

## 0.7.0

- Updated internal firebase-tools dependency to 13.16.0
Expand Down
4 changes: 0 additions & 4 deletions firebase-vscode/src/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,6 @@ export async function login() {
}

export async function listProjects() {
const loggedInUser = await requireAuthWrapper(false);
if (!loggedInUser) {
return [];
}
return listFirebaseProjects();
}

Expand Down
2 changes: 1 addition & 1 deletion firebase-vscode/src/core/user.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const isServiceAccount = computed(() => {
});

export async function checkLogin() {
return await requireAuthWrapper();
return await requireAuthWrapper();
}

export function registerUser(broker: ExtensionBrokerImpl, telemetryLogger: TelemetryLogger): Disposable {
Expand Down