Implement schemaValidation mode handling in firebase dataconnect:sql:diff
#7633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosalyntan
changed the title
firebase dataconnect:sql:diff
joehan
reviewed
Sep 10, 2024
joehan
reviewed
Sep 10, 2024
joehan
approved these changes
Sep 10, 2024
Contributor
joehan
left a comment
joehan
left a comment
There was a problem hiding this comment.
Small nits, but code LGTM - lets just make sure to test after backend changes roll out
tammam-g
pushed a commit
that referenced
this pull request
Sep 13, 2024
…:diff` (#7633) * Compat mode support. * Support handling schema validation options in `diff`. * Fix build. * Format. * Don't output second set of diffs if they're equal to the first. * Address review comments. * Tweak output logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the
firebase dataconnect:sql:diffcommand per go/fdc-compat-mode-cli-api.firebase init,firebase dataconnect:sql:migrate, andfirebase deploywill be updated in later PRs.Scenarios Tested
NOTE: Tested against the staging API, as compat mode changes have not yet rolled out to prod.
schemaValidationunset in dataconnect.yaml, has both required and optional changes:schemaValidationunset in dataconnect.yaml, has only required changes:schemaValidationunset in dataconnect.yaml, has only optional changes:schemaValidation: STRICTin dataconnect.yaml, has both required and optional changes:schemaValidation: COMPATIBLEin dataconnect.yaml, has both required and optional changes:Sample Commands