Update add data #7753
Merged
Update add data #7753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuchenshi
approved these changes
Sep 26, 2024
Co-authored-by: Yuchen Shi <yuchenshi@google.com>
Co-authored-by: Yuchen Shi <yuchenshi@google.com>
Co-authored-by: Yuchen Shi <yuchenshi@google.com>
tjlav5
reviewed
Sep 27, 2024
| case "UUID": | ||
| return { kind: Kind.STRING, value: "1111-2222-3333-44444" }; | ||
| case "Vector": | ||
| return { kind: Kind.LIST, values: [] }; |
Contributor
There was a problem hiding this comment.
I forget where we landed w/ this during the bash... should this be omitted or an empty list?
Contributor
Author
There was a problem hiding this comment.
Not following, for vectors?
Contributor
There was a problem hiding this comment.
I think the point here is that an empty vector is very likely to be invalid (due to the size directive), so it may be unhelpful to put it there. FWIW, i don't see a great way to handle required vectors here either.
tjlav5
reviewed
Sep 27, 2024
yuchenshi
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.