Skip to content

chore: update dependencies for firebase functions template #7809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 16, 2024
Merged

chore: update dependencies for firebase functions template #7809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a8aebff
chore: update dependencies for firebase functions templete
emwp Oct 8, 2024
1ad2deb
chore: changelog
emwp Oct 8, 2024
62f841d
chore: remove comment
emwp Oct 8, 2024
37c8300
Merge branch 'master' of github.com:firebase/firebase-tools into chor…
emwp Oct 10, 2024
897e266
Merge branch 'master' of github.com:firebase/firebase-tools into chor…
emwp Oct 11, 2024
bd108b7
Merge branch 'master' into chore/update-functions-template-dependencies
emwp Oct 11, 2024
1f60982
Merge branch 'master' into chore/update-functions-template-dependencies
emwp Oct 15, 2024
d030aa0
Merge branch 'master' into chore/update-functions-template-dependencies
joehan Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
- Updated dependencies in functions initialization template. (#7809)
- Fixed Flutter web apps that might require the --no-tree-shake-icons flag in order to build. (#7724)
- Removed outdated dependency on `rimraf`.
- Fixed an issue where the Extensions emulator would fail silently if started with a non-existant project without the `demo-` prefix. (#7779)
Expand Down
2 changes: 1 addition & 1 deletion src/frameworks/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
export const FIREBASE_FRAMEWORKS_VERSION =
(experiments.isEnabled("internaltesting") && process.env.FIREBASE_FRAMEWORKS_VERSION) ||
DEFAULT_FIREBASE_FRAMEWORKS_VERSION;
export const FIREBASE_FUNCTIONS_VERSION = "^4.5.0";
export const FIREBASE_FUNCTIONS_VERSION = "^6.0.1";
export const FIREBASE_ADMIN_VERSION = "^11.11.1";
export const SHARP_VERSION = "^0.32 || ^0.33";
export const NODE_VERSION = parseInt(process.versions.node, 10);
Expand Down Expand Up @@ -73,10 +73,10 @@

export const I18N_ROOT = "/";

export function GET_DEFAULT_BUILD_TARGETS() {

Check warning on line 76 in src/frameworks/constants.ts

View workflow job for this annotation

GitHub Actions / lint (20) 

Missing return type on function

Check warning on line 76 in src/frameworks/constants.ts

View workflow job for this annotation

GitHub Actions / lint (20) 

Missing JSDoc comment
return Promise.resolve(["production", "development"]);
}

export function DEFAULT_SHOULD_USE_DEV_MODE_HANDLE(target: string) {

Check warning on line 80 in src/frameworks/constants.ts

View workflow job for this annotation

GitHub Actions / lint (20) 

Missing return type on function

Check warning on line 80 in src/frameworks/constants.ts

View workflow job for this annotation

GitHub Actions / lint (20) 

Missing JSDoc comment
return Promise.resolve(target === "development");
}
4 changes: 2 additions & 2 deletions templates/extensions/javascript/package.lint.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
"description": "Greet the world",
"main": "index.js",
"dependencies": {
"firebase-admin": "^12.1.0",
"firebase-functions": "^5.0.0"
"firebase-admin": "^12.6.0",
"firebase-functions": "^6.0.1"
Comment on lines +6 to +7
Copy link
Member

@leoortizz leoortizz Oct 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this impact web frameworks too? What happens if we keep it as before?

Copy link
Contributor Author

@emwp emwp Oct 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leoortizz Upgraded the extensions as well since last time an upgrade like this was done, it was requested the extensions to be done as well, see:
#7084 (review)

Can be removed if you think it's better!

Copy link
Contributor

@joehan joehan Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not related to web frameworks, this is for ext:dev:init. We should keep these changes to templates/extensions

},
"devDependencies": {
"eslint": "^8.15.1",
Expand Down
4 changes: 2 additions & 2 deletions templates/extensions/javascript/package.nolint.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
"description": "Greet the world",
"main": "index.js",
"dependencies": {
"firebase-admin": "^12.1.0",
"firebase-functions": "^5.0.0"
"firebase-admin": "^12.6.0",
"firebase-functions": "^6.0.1"
},
"devDependencies": {
"axios": "^1.3.2",
Expand Down
4 changes: 2 additions & 2 deletions templates/extensions/typescript/package.lint.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
},
"main": "lib/index.js",
"dependencies": {
"firebase-admin": "^12.1.0",
"firebase-functions": "^5.0.0"
"firebase-admin": "^12.6.0",
"firebase-functions": "^6.0.1"
},
"devDependencies": {
"@types/chai": "^4.3.4",
Expand Down
4 changes: 2 additions & 2 deletions templates/extensions/typescript/package.nolint.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
},
"main": "lib/index.js",
"dependencies": {
"firebase-admin": "^12.1.0",
"firebase-functions": "^5.0.0"
"firebase-admin": "^12.6.0",
"firebase-functions": "^6.0.1"
},
"devDependencies": {
"@types/chai": "^4.3.4",
Expand Down
4 changes: 2 additions & 2 deletions templates/init/functions/javascript/package.lint.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
},
"main": "index.js",
"dependencies": {
"firebase-admin": "^12.1.0",
"firebase-functions": "^5.0.0"
"firebase-admin": "^12.6.0",
"firebase-functions": "^6.0.1"
},
"devDependencies": {
"eslint": "^8.15.0",
Expand Down
4 changes: 2 additions & 2 deletions templates/init/functions/javascript/package.nolint.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
},
"main": "index.js",
"dependencies": {
"firebase-admin": "^12.1.0",
"firebase-functions": "^5.0.0"
"firebase-admin": "^12.6.0",
"firebase-functions": "^6.0.1"
},
"devDependencies": {
"firebase-functions-test": "^3.1.0"
Expand Down
4 changes: 2 additions & 2 deletions templates/init/functions/typescript/package.lint.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
},
"main": "lib/index.js",
"dependencies": {
"firebase-admin": "^12.1.0",
"firebase-functions": "^5.0.0"
"firebase-admin": "^12.6.0",
"firebase-functions": "^6.0.1"
},
"devDependencies": {
"@typescript-eslint/eslint-plugin": "^5.12.0",
Expand Down
4 changes: 2 additions & 2 deletions templates/init/functions/typescript/package.nolint.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
},
"main": "lib/index.js",
"dependencies": {
"firebase-admin": "^12.1.0",
"firebase-functions": "^5.0.0"
"firebase-admin": "^12.6.0",
"firebase-functions": "^6.0.1"
},
"devDependencies": {
"typescript": "^4.9.0",
Expand Down
Loading