Centralize logs when not in a firebase directory #7811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuchenshi
reviewed
Oct 8, 2024
| const rootFolders = getRootFolders(); | ||
| const filePath = path.join(rootFolders[0], ".firebase", "logs", "vsce-debug.log"); | ||
| // Default to a central path, but write files to a local path if we're in a Firebase directory. | ||
| let filePath = "~/.cache/firebase/vscode/vsce-debug.log"; |
Member
There was a problem hiding this comment.
Suggested change
| let filePath = "~/.cache/firebase/vscode/vsce-debug.log"; | |
| let filePath = "~/.cache/firebase/logs/vsce-debug.log"; |
And we also need a random segment to prevent conflicts across multiple windows.
And speaking of windows... Does it work on Windows (capital W)?
Member
There was a problem hiding this comment.
And... one last thing, please use require('os').homedir() instead of ~ for portability
Contributor
Author
There was a problem hiding this comment.
Good calls, done. Ignoring the random segment bit for now - different instances will write to the same log, which is fine for now imo.
hlshen
reviewed
Oct 8, 2024
hlshen
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When not inside a firebase directory, write logs to
~/.cache/firebase/vscode.~/.cache/firebaseis already used by other places in the CLI.