Import + export support for the data connect emulator #7836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joehan
changed the title
yuchenshi
approved these changes
Nov 15, 2024
| return Emulators.DATACONNECT; | ||
| } | ||
|
|
||
| async clearData(): Promise<void> { |
Member
There was a problem hiding this comment.
Can one still clear the DB even if running a separate postgres? I'd say yes, but any concerns?
Contributor
Author
There was a problem hiding this comment.
That's a good product q - I think it's reasonable to offer, but if they're connecting to a real DB that becomes a pretty scary big red button.
Contributor
Author
There was a problem hiding this comment.
Chatted in local tooling sync - decision is that this is ok, as long as we have a confirmation dialogue in vsce
Member
There was a problem hiding this comment.
But given the code as it is written right now, this seems to noop if it's not using pglite.
I think it should either do what it says on the label, or fail with a clear error message (e.g. "unimplemented"), but not noop.
src/emulator/hub.ts
Outdated
| }); | ||
|
|
||
| app.post(EmulatorHub.PATH_CLEAR_DATA_CONNECT, async (req, res) => { | ||
| // TODO: Sanity check that this is needed. |
…se-tools into jh-persistence-prototype
joehan
added a commit
that referenced
this pull request
Nov 21, 2024
joehan
added a commit
that referenced
this pull request
Nov 21, 2024
joehan
added a commit
that referenced
this pull request
Nov 21, 2024
joehan
added a commit
that referenced
this pull request
Nov 21, 2024
joehan
added a commit
that referenced
this pull request
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for data persistence between runs of the data conect emulator, as described in go/fdc-emu-import-api
Scenarios Tested
emulator:exportand confirmed that it outputs a tarball database dump in the export directory.--importand confirmed that the same data is there after import.Follow up work