Skip to content

Conversation

@joehan
Copy link
Contributor

@joehan joehan commented Dec 2, 2024

Description

Add no-undeclared-imports eslint rule - this means importing something not declared in package.json (like an indirect dependency) will be a linter error.

This also caught a few cases of us using types from indirect dependencies - this isn't a runtime error (since types get washed away during compile), but it is ugly, so I added those as devDeps.

@joehan joehan requested review from bkendall and mathu97 and removed request for bkendall and mathu97 December 2, 2024 19:27
@joehan
Copy link
Contributor Author

joehan commented Dec 2, 2024

Broke the build, will resend once i fix that.

@joehan joehan requested review from bkendall and mathu97 December 4, 2024 17:39
@joehan joehan enabled auto-merge (squash) December 4, 2024 20:04
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.15%. Comparing base (49c5ac5) to head (60ceb90).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8017      +/-   ##
==========================================
- Coverage   51.19%   51.15%   -0.05%     
==========================================
  Files         423      423              
  Lines       29544    29577      +33     
  Branches     6031     6040       +9     
==========================================
+ Hits        15125    15130       +5     
- Misses      13059    13087      +28     
  Partials     1360     1360              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joehan joehan merged commit 9ad8df3 into master Dec 4, 2024
42 of 45 checks passed
@joehan joehan deleted the jh-no-undeclared branch December 4, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants