Add prompt if user deploys a genkit function without a secret #8138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taeold
approved these changes
Jan 27, 2025
src/deploy/functions/prepare.ts
Outdated
Comment on lines
527
to
537
| const msgBase = | ||
| `The function(s) ${newAndMissingSecrets.map((e) => e.id).join(", ")} use Genkit but do not have access to a secret. ` + | ||
| "This may cause the function to fail if it depends on an API key. To learn more about granting a function access to " + | ||
| "secrets, see https://firebase.google.com/docs/functions/config-env?gen=2nd#secret_parameters."; | ||
| if (options.nonInteractive) { | ||
| throw new FirebaseError(msgBase); | ||
| } | ||
| if (!(await prompt.confirm({ message: `${msgBase} Continue?` }))) { | ||
| throw new FirebaseError("Aborted"); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
nit* prompts.confirm has logic to short-circuit if nonInteractive is passed. So could be re-written to:
logLabledBullet(msgBase);
if (!(await prompt.confirm({ nonInteractive: options.nonInteractive, force: options.force }))) {
throw new FirebaseError("Aborted");
}Slightly different behavior in messaging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redundant warning with the SDK after @taeold made a good point that the error isn't visible during deployment. Probably worth keeping the other one around anyway since this doesn't warn if the function already existed.