Skip to content

Don't surface insecure operations errors in VSCode. #8215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 18, 2025
Merged

Don't surface insecure operations errors in VSCode. #8215

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
57cb7fe
Don't surface connector evolution or insecure operation issues in VSC…
rosalyntan Feb 13, 2025
f500171
Fix
rosalyntan Feb 13, 2025
8e1a738
Filter by "INSECURE" substring rather than warningLevel.
rosalyntan Feb 14, 2025
760936b
Merge branch 'master' into rosalyntan.vscode
rosalyntan Feb 14, 2025
a64bbfe
Merge branch 'master' into rosalyntan.vscode
hlshen Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions firebase-vscode/src/data-connect/core-compiler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,10 @@ function convertGQLErrorToDiagnostic(
const perFileDiagnostics: Record<string, Diagnostic[]> = {};
const dcPath = configs.values[0].path;
for (const error of gqlErrors) {
if (error.message.includes("INSECURE")) {
// Don't surface insecure operation issues for now; we need to be able to compare with a deployed source for these to be accurately presented.
continue;
}
const absFilePath = `${dcPath}/${error.extensions["file"]}`;
const perFileDiagnostic = perFileDiagnostics[absFilePath] || [];
perFileDiagnostic.push({
Expand Down
Loading