Provide firebase login credentials to Data connect emulator #8342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlshen
approved these changes
Mar 20, 2025
Contributor
hlshen
left a comment
hlshen
left a comment
There was a problem hiding this comment.
Approved; Do we need to add any safety checks for account not existing?
rosalyntan
reviewed
Mar 20, 2025
| return; | ||
| } | ||
| for (const conn of serviceInfo.connectorInfo) { | ||
| const account = getProjectDefaultAccount(options.projectRoot); |
Member
There was a problem hiding this comment.
I think it's just fdc build and fdc dev that need the credentials (not fdc generate)
Contributor
Author
There was a problem hiding this comment.
Yeah, I figured we ought to provide them as future proofing.
rosalyntan
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide default credentials to Data Connect emulator so that it can make calls to the vertex and data connect APIs.