Skip to content

Conversation

@joehan
Copy link
Contributor

@joehan joehan commented May 9, 2025

Description

Fixes #8519

@joehan joehan enabled auto-merge (squash) May 9, 2025 17:13
Copy link
Contributor

@aalej aalej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 51.10%. Comparing base (b8bbe0f) to head (564233b).
Report is 20 commits behind head on master.

Files with missing lines Patch % Lines
src/ensureApiEnabled.ts 66.66% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8531   +/-   ##
=======================================
  Coverage   51.09%   51.10%           
=======================================
  Files         425      425           
  Lines       30463    30479   +16     
  Branches     6260     6261    +1     
=======================================
+ Hits        15565    15576   +11     
- Misses      13508    13516    +8     
+ Partials     1390     1387    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joehan joehan disabled auto-merge May 9, 2025 17:21
@joehan joehan enabled auto-merge (squash) May 9, 2025 17:26
@joehan joehan disabled auto-merge May 9, 2025 17:27
@joehan joehan enabled auto-merge (squash) May 9, 2025 17:34
@joehan joehan merged commit 8040437 into master May 9, 2025
50 checks passed
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions May 9, 2025
blidd-google pushed a commit that referenced this pull request May 12, 2025
* Accidentally expanded the required permissions for firebase use

* Await

* fix + type

* typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Authenticating with GOOGLE_APPLICATION_CREDENTIALS broken

3 participants