-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Minor updates to the deploy prompt to improve UX for choosing a Fireb… #9075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @jpreid7396, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request refines the user experience during the Firebase deployment prompt, specifically around how users select or confirm a Firebase project. The changes aim to provide more control and clarity to the user by introducing explicit confirmation for active projects and making project listing an on-demand action, thereby streamlining the overall deployment flow.
Highlights
- Improved Active Project Handling: When an active Firebase project is detected, the user is now explicitly prompted with the project ID and asked for confirmation to proceed, rather than automatically using it.
- Streamlined Project Selection Options: If no active project is found, the options are clarified to "Provide an existing project id" or "create a new project".
- On-Demand Project Listing: The
firebase_list_projectstool will now only be invoked if the user explicitly requests to list projects, preventing unnecessary calls and improving prompt responsiveness.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the deployment prompt to improve the user experience when selecting a Firebase project. The changes clarify the process for both scenarios: when an active project exists and when one doesn't. My review includes a suggestion to standardize the casing of 'project ID' for better consistency across the codebase, which is important for the clarity of instructions given to the AI model.
…ase project
Description
Scenarios Tested
Sample Commands