-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update FDC local toolkit to v2.15.0 #9323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @lisajian, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on upgrading the Firebase Data Connect (FDC) local toolkit to version 2.15.0. This update ensures that the Firebase CLI is configured to download and use the latest Data Connect emulator binaries, bringing the most recent features and stability improvements to local development environments. The changes primarily involve updating configuration metadata for the emulator downloads and noting a specific improvement in Dart-generated code. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Data Connect local toolkit to version 2.15.0. The changes correctly update the emulator download details in src/emulator/downloadableEmulatorInfo.json and add a corresponding entry to CHANGELOG.md. The changes look good, with just one minor suggestion for consistency in the changelog.
CHANGELOG.md
Outdated
| @@ -1,2 +1,3 @@ | |||
| - Add a confirmation in `firebase init dataconnect` before asking for app idea description. (#9282) | |||
| - Add a command `firebase dataconnect:execute` to run queries and mutations (#9274). | |||
| - Dart: Generated objects use Object.hashAll() | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Scenarios Tested
Sample Commands