Skip to content

Conversation

@samedson
Copy link
Contributor

@samedson samedson commented Oct 24, 2025

Description

Build, but don't run Agent Evals per-commit. These run too slowly to be run that frequently.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @samedson, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a dedicated build command for the agent-evals module. By adding a build script to its package.json, the change formalizes the compilation process for this specific component, allowing for clearer separation and management of its TypeScript compilation.

Highlights

  • Build Script Addition: A new build script has been added to the package.json for the agent-evals module, which executes the TypeScript compiler (tsc).
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/node-test.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a build script to the agent-evals package. This is a useful addition. My review includes a suggestion to refactor the test and test:dev scripts to leverage this new build script. This will improve the clarity of the scripts and fix an issue where test:dev was not behaving as expected.

strategy:
matrix:
node-version:
- "20"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably unnecessary to run this on 2 versions of node. We don't ship this code, so the cost of breaking it accidentally is low (and its pretty uncommon to break things on just one node version)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah was wondering what the two versions were for

@samedson samedson enabled auto-merge (squash) October 24, 2025 17:23
@samedson samedson merged commit 4445ee9 into master Oct 24, 2025
50 checks passed
@samedson samedson deleted the 10-24-samedson-ae-gh-build branch October 24, 2025 17:36
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants