-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update Agent Evals to run in a custom home directory #9427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @samedson, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the robustness and isolation of the Agent Evals system by introducing a custom home directory for Gemini CLI runs. This strategic change ensures that evaluations can leverage advanced Gemini CLI features like memory and extensions without interfering with a developer's local setup, while also streamlining the setup process by eliminating the need to clear existing MCP servers. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the agent evaluation tests to run within a custom home directory, which is an excellent improvement for test isolation. By setting the HOME environment variable for the Gemini CLI process, you've effectively sandboxed the tests, preventing interference with the user's global configuration. The introduction of RunDirectories and the new helper methods in GeminiCliRunner make the code cleaner and more modular. I've added a couple of suggestions to further improve type safety and robustness in gemini-cli-runner.ts. Overall, this is a solid change that enhances the reliability of the test suite.
schnecle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Thanks Sam!
Description
Allows us to use features like Gemini CLI memory, extensions, etc.
Also removes the need to mess with the user's real MCP servers.