-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update Changelog to include FDC Generated Admin SDKs #9431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @JeyoosJ, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project's changelog to accurately document a new capability of the Data Connect emulator. Specifically, it clarifies that version 2.17.0 of the emulator now includes support for Generated Admin SDKs, ensuring that the public record of changes is up-to-date and comprehensive. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the changelog to reflect that version 2.17.0 of the Data Connect emulator now supports Generated Admin SDKs. My review includes a minor grammatical suggestion to improve the clarity of the changelog entry.
CHANGELOG.md
Outdated
| - Adds 2nd gen Firebase Data Connect triggers to firebase deploy (#9394). | ||
| - Upgrades `@google-cloud/pubsub` to `v5` (#9428). | ||
| - Updated to v2.17.0 of the Data Connect emulator, which includes internal improvements (#9430). | ||
| - Updated to v2.17.0 of the Data Connect emulator which contains internal improvements and now supports Generated Admin SDKs (#9430). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For grammatical correctness, a comma should be placed before 'which' when it introduces a non-restrictive clause like this one. This improves the readability of the sentence.
| - Updated to v2.17.0 of the Data Connect emulator which contains internal improvements and now supports Generated Admin SDKs (#9430). | |
| - Updated to v2.17.0 of the Data Connect emulator, which contains internal improvements and now supports Generated Admin SDKs (#9430). |
No description provided.