-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fixed googleapis issue #9445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed googleapis issue #9445
Conversation
Summary of ChangesHello @bkendall, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to optimize the application by removing the dependency on the large Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully replaces the googleapis dependency with a custom API handler for fetching the app testing environment catalog, which is a great move to reduce the overall package size. The implementation is solid, but I have a couple of suggestions to enhance type safety and add robustness to the new logic.
| if (getAvailableDevices) { | ||
| const testing = google.testing("v1"); | ||
| devices = await testing.testEnvironmentCatalog.get({ | ||
| oauth_token: await getAccessToken(), | ||
| environmentType: "ANDROID", | ||
| }); | ||
| devices = await testEnvironmentCatalog(projectId || "", "ANDROID"); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing an empty string for projectId when it's missing could lead to a cryptic backend error. Since this tool now explicitly requires a project, it's safer to fail fast with a clear error message if projectId is not available. Please add a check to ensure projectId is present before making the API call.
if (getAvailableDevices) {
if (!projectId) {
throw new FirebaseError("Project ID is required to get available devices but is missing.");
}
devices = await testEnvironmentCatalog(projectId, "ANDROID");
}| type TestEnvironmentCatalog = unknown; | ||
|
|
||
| /** | ||
| * Gets the catalog of supported test environments. | ||
| */ | ||
| export async function testEnvironmentCatalog( | ||
| projectId: string, | ||
| environmentType: EnvironmentType, | ||
| ): Promise<unknown> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using unknown for TestEnvironmentCatalog and the function's return type reduces type safety and makes the response harder to work with for consumers of this function. It would be beneficial to define a proper type for the TestEnvironmentCatalog based on the expected API response structure. Even a partial type definition with a TODO to fill it out later would be an improvement over unknown.
| type TestEnvironmentCatalog = unknown; | |
| /** | |
| * Gets the catalog of supported test environments. | |
| */ | |
| export async function testEnvironmentCatalog( | |
| projectId: string, | |
| environmentType: EnvironmentType, | |
| ): Promise<unknown> { | |
| interface TestEnvironmentCatalog { | |
| // TODO: Define the properties of the test environment catalog based on the API response. | |
| } | |
| /** | |
| * Gets the catalog of supported test environments. | |
| */ | |
| export async function testEnvironmentCatalog( | |
| projectId: string, | |
| environmentType: EnvironmentType, | |
| ): Promise<TestEnvironmentCatalog> { |
Description
Replaces usage of
googleapiswith a custom API handler. We try not to includegoogleapisbecause it's such a large package.Fixes #9443