Skip to content

Conversation

@taeold
Copy link
Contributor

@taeold taeold commented Nov 17, 2025

This will stop createing firebase-test* folder in the workspace every time you run npm run test.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @taeold, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the way temporary directories are handled within tests. By consistently using os.tmpdir() for temporary file creation, the changes ensure that test-related artifacts are stored in the appropriate system-level temporary location, thereby preventing clutter in the local project workspace and improving overall test environment hygiene.

Highlights

  • Temporary Directory Creation: Tests now create temporary directories using os.tmpdir() to ensure they are placed in the system's standard temporary location.
  • Workspace Cleanliness: This change prevents firebase-test* folders from being created directly in the project workspace, leading to a cleaner development environment after running tests.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@taeold taeold enabled auto-merge (squash) November 17, 2025 18:25
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the tests to create temporary directories in the operating system's temporary directory, which is a great improvement to avoid polluting the project workspace. The changes are correct and achieve the intended goal. I've added one suggestion to further improve the test code by reducing duplication using a beforeEach hook, which would make the tests more maintainable.

@taeold taeold merged commit d68aa33 into master Nov 17, 2025
48 checks passed
@taeold taeold deleted the stop-tmp branch November 17, 2025 18:41
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Nov 17, 2025
kdawgwilk pushed a commit to kdawgwilk/firebase-tools that referenced this pull request Nov 20, 2025
kdawgwilk pushed a commit to kdawgwilk/firebase-tools that referenced this pull request Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants