-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: add node.js 24 runtime support with beta status #9475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @kdawgwilk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates Node.js 24 as a supported runtime for Firebase Cloud Functions. This enhancement provides users with access to the latest Node.js version for their serverless deployments, ensuring compatibility with modern language features and performance improvements. The new runtime is initially available in beta, with clearly defined deprecation and decommission dates to guide future planning. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for the Node.js 24 runtime, marking it as beta. The change itself in types.ts looks correct. However, the implementation appears to be incomplete. I've left a comment regarding missing test coverage for the new runtime and a potential omission in updating the ActiveRuntime type, which is crucial for allowing users to specify nodejs24 in their firebase.json configuration. Please address these points to ensure the feature is complete and well-tested.
fcc11c0 to
1ab92d9
Compare
taeold
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for your contribution 🙏. one nit comment
1ab92d9 to
a946647
Compare
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for the Node.js 24 runtime. While the change is straightforward, I've found a likely error in the decommissionDate for the new runtime, which I've left a comment on. Additionally, this change should be accompanied by new tests in src/deploy/functions/runtimes/supported/supported.spec.ts to verify that the new runtime is correctly handled by functions like isRuntime and latest.
|
Looks like CI jobs are stuck? |
Description
Adds support for Node.js 24 runtime for Firebase Cloud Functions. This change introduces the
nodejs24runtime configuration with appropriate lifecycle dates based on the official Node.js release schedule.Key details:
beta(Node.js 24.x is currently in Active LTS phase as "Krypton")Fixes #9422
Scenarios Tested
firebase.jsonconfigurationruntime: "nodejs24"npm testto ensure all tests passSample Commands
Deploying a function with Node.js 24 runtime:
In firebase.json
{ "functions": { "runtime": "nodejs24" } }firebase deploy --only functionsOr specify in individual function configuration: