Skip to content

Conversation

@kdawgwilk
Copy link
Contributor

Description

Adds support for Node.js 24 runtime for Firebase Cloud Functions. This change introduces the nodejs24 runtime configuration with appropriate lifecycle dates based on the official Node.js release schedule.

Key details:

  • Runtime status: beta (Node.js 24.x is currently in Active LTS phase as "Krypton")
  • Deprecation date: April 30, 2028 (matches Node.js 24.x official EOL)
  • Decommission date: October 31, 2028 (follows the pattern established for previous Node.js runtimes)

Fixes #9422

Scenarios Tested

  • Verified the new runtime option appears in runtime validation
  • Confirmed the runtime can be specified in firebase.json configuration
  • Tested deploying a function with runtime: "nodejs24"
  • Validated that the runtime lifecycle dates are correctly recognized by the CLI
  • Ran npm test to ensure all tests pass

Sample Commands

Deploying a function with Node.js 24 runtime:

In firebase.json

{
  "functions": {
    "runtime": "nodejs24"
  }
}

firebase deploy --only functionsOr specify in individual function configuration:

// In your functions code
exports.myFunction = functions
  .runWith({ runtime: 'nodejs24' })
  .https.onRequest((req, res) => {
    // Your function code
  });

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @kdawgwilk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates Node.js 24 as a supported runtime for Firebase Cloud Functions. This enhancement provides users with access to the latest Node.js version for their serverless deployments, ensuring compatibility with modern language features and performance improvements. The new runtime is initially available in beta, with clearly defined deprecation and decommission dates to guide future planning.

Highlights

  • Node.js 24 Runtime Support: This pull request introduces support for the Node.js 24 runtime for Firebase Cloud Functions, enabling developers to utilize the latest Node.js features for their serverless deployments.
  • Beta Status and Lifecycle Dates: The new nodejs24 runtime is added with a 'beta' status, a deprecation date of April 30, 2028, and a decommission date of October 31, 2028, aligning with the official Node.js release schedule.
  • Configuration Options: Developers can specify nodejs24 as the runtime either in their firebase.json configuration or directly within individual function definitions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the Node.js 24 runtime, marking it as beta. The change itself in types.ts looks correct. However, the implementation appears to be incomplete. I've left a comment regarding missing test coverage for the new runtime and a potential omission in updating the ActiveRuntime type, which is crucial for allowing users to specify nodejs24 in their firebase.json configuration. Please address these points to ensure the feature is complete and well-tested.

@kdawgwilk kdawgwilk force-pushed the bugfix/node_24_runtime branch from fcc11c0 to 1ab92d9 Compare November 17, 2025 20:31
Copy link
Contributor

@taeold taeold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your contribution 🙏. one nit comment

@kdawgwilk kdawgwilk force-pushed the bugfix/node_24_runtime branch from 1ab92d9 to a946647 Compare November 17, 2025 23:41
@taeold
Copy link
Contributor

taeold commented Nov 18, 2025

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the Node.js 24 runtime. While the change is straightforward, I've found a likely error in the decommissionDate for the new runtime, which I've left a comment on. Additionally, this change should be accompanied by new tests in src/deploy/functions/runtimes/supported/supported.spec.ts to verify that the new runtime is correctly handled by functions like isRuntime and latest.

@taeold taeold enabled auto-merge (squash) November 18, 2025 19:06
@kdawgwilk
Copy link
Contributor Author

Looks like CI jobs are stuck?

@taeold taeold merged commit 644808c into firebase:master Nov 19, 2025
44 checks passed
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Nov 19, 2025
@kdawgwilk kdawgwilk deleted the bugfix/node_24_runtime branch November 19, 2025 22:28
@kdawgwilk kdawgwilk mentioned this pull request Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node 24 warning

2 participants