FDC free trial #9494
FDC free trial #9494
Conversation
Summary of ChangesHello @tammam-g, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates comprehensive support for Firebase Data Connect free trial instances. It modifies the Cloud SQL provisioning logic to allow for the creation of a single, no-cost Cloud SQL instance for projects without an active billing account. The changes also update the command-line interface's initialization process to guide users through selecting either a free trial or a paid instance, ensuring that the free trial is a one-time offering per project and providing clear upgrade instructions when necessary. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for a free trial for Firebase Data Connect, which is a great addition. The changes correctly modify the init flow to handle free trial instance creation and add necessary checks for billing when creating paid instances. The tests have also been updated to reflect these new scenarios. I've found one medium-severity issue in the interactive prompt logic where a user isn't offered to create a new CloudSQL instance if none exist. I've provided a suggestion to fix this to improve the user experience. Overall, the changes are well-implemented.
src/gcp/cloudsql/cloudsqladmin.ts
Outdated
| ); | ||
| } | ||
| if (args.freeTrialLabel === "ft" && !billingEnabled && !instrumentlessTrialEnabled) { | ||
| throw new FirebaseError(`You need an active billing account to create free trial instance`); |
There was a problem hiding this comment.
[blocking] Include the old upgrade message here
"Local flag for enabling instrumentless billing disabled" case above should print the same message as in master branch.
There was a problem hiding this comment.
Ok, fixed we don't do anything here but during the prompting we will skip the whole flow here if billing isn't enabled (same behaviour as before)
github-project-automation
bot
moved this to Changes Requested [PR]
in [Cloud] Extensions + Functions
github-project-automation
bot
moved this from Changes Requested [PR]
to Approved [PR]
in [Cloud] Extensions + Functions
github-project-automation
bot
moved this from Approved [PR]
to Done
in [Cloud] Extensions + Functions
3 participants
Description
Adds sql free trial creation and handling
Scenarios Tested
Create a free trial instance on spark account
Try to create a second free trial instance when a free trial instance exists
Delete free instance with gcloud and make sure we still can't create instance
Free trial in constraint location
Local flag for enabling instrumentless billing disabled
Free trial created on non whitelisted Blaze plan account (current common case):
Sample Commands