-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update firebase init functions template to latest SDK versions #9496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @jhuleatt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the default dependency versions for Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Firebase SDK versions in the function initialization templates. The version bumps for firebase-admin, firebase-functions, and firebase-functions-test are applied consistently across all JavaScript and TypeScript templates. The changes align with the goal of providing the latest SDKs for new projects. While the changes themselves are correct, the update includes major version increments for firebase-admin (v12 to v13) and firebase-functions (v6 to v7), which can introduce breaking changes. The pull request description states that no scenarios were tested. Given that these templates are the foundation for new user projects, it is highly recommended to perform integration tests by running firebase init functions and verifying that the generated project builds and runs correctly with these new dependency versions to prevent issues for developers starting new projects.
Description
Update
firebase-functions,firebase-admin, andfirebase-functions-testin thefirebase init functionstemplates.Scenarios Tested
n/a
Sample Commands