-
Notifications
You must be signed in to change notification settings - Fork 52
[FirebaseAI] Add support for Server Prompt Templates #1361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @a-maurice, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Firebase AI SDK by integrating support for server prompt templates. This feature allows developers to define and manage AI prompts on the server, then invoke them from the client with dynamic inputs. This abstraction simplifies prompt engineering, promotes reusability, and enables more flexible and powerful AI-driven applications, covering both text generation and image creation scenarios. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for Server Prompt Templates for both generative and Imagen models. The changes include new model classes (TemplateGenerativeModel and TemplateImagenModel), corresponding factory methods in FirebaseAI, and helper methods for URL construction. Additionally, automated tests have been added to verify the new functionality. The implementation is solid, but I have a few suggestions to improve code organization and reduce duplication, such as moving a class to its own file and refactoring a helper method for better clarity.
Description
Add logic to support using Server Prompt Templates to generate content. Add automated tests. Also, update imagen tests to use 4 instead of 3.
Testing
Running locally
Type of Change
Place an
xthe applicable box: